Skip to content

feat: add _meta support to CreateElicitationResult#792

Merged
alexhancock merged 1 commit intomodelcontextprotocol:mainfrom
mzeng-openai:dev/mzeng/meta_create_elicitation_result
Apr 8, 2026
Merged

feat: add _meta support to CreateElicitationResult#792
alexhancock merged 1 commit intomodelcontextprotocol:mainfrom
mzeng-openai:dev/mzeng/meta_create_elicitation_result

Conversation

@mzeng-openai
Copy link
Copy Markdown
Contributor

Summary

  • add optional _meta metadata to CreateElicitationResult
  • add with_meta() builder and preserve None defaults at existing call sites
  • cover _meta serialization/deserialization and refresh JSON-RPC schema snapshots

Tests

  • cargo +nightly fmt --all --check
  • cargo check -p rmcp --all-targets --all-features
  • cargo check -p mcp-conformance --all-targets
  • cargo test -p rmcp --test test_elicitation test_elicitation_result_serialization --features "elicitation client server"
  • cargo test -p rmcp --test test_message_schema --all-features
  • git diff --check

@mzeng-openai mzeng-openai requested a review from a team as a code owner April 7, 2026 23:07
@github-actions github-actions bot added T-test Testing related changes T-config Configuration file changes T-core Core library changes T-handler Handler implementation changes labels Apr 7, 2026
Copy link
Copy Markdown
Contributor

@alexhancock alexhancock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thank you

@alexhancock alexhancock merged commit 5f43283 into modelcontextprotocol:main Apr 8, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-config Configuration file changes T-core Core library changes T-handler Handler implementation changes T-test Testing related changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants